Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add file processing tests #3

Merged
merged 3 commits into from
Jun 8, 2024

Conversation

sealbell
Copy link
Contributor

@sealbell sealbell commented Jun 8, 2024

🫰 Thanks for your Pull Request! Here are some helpful tips:

👀 Purpose and Importance of this PR:

  • My code conforms to the coding style of this project.
  • My code requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All tests have passed.

🅰 Fixes for Issues:

Fixes 解析Excel并支持多种输出格式#5

📝 Notes for the Reviewer:

This PR adds the ExcelConverter class in excel_parser.py for parsing and converting Excel files to JSON. It also includes the remove_keys_from_json function in json_validator.py to remove specified keys from JSON strings. Additionally, unit tests for these functionalities are provided in test_file_processing.py.

🎯 How to Verify this PR:

  • In the project root directory, run the following command to execute the unit tests and verify the functionality of ExcelConverter and remove_keys_from_json:

    python -m unittest discover -s tests
  • Ensure the provided sample Excel file and JSON strings match the expected output.

📑 Additional Documentation, e.g., KEPs (Enhancement Proposals), Usage Docs, etc.:

No additional documentation required.

@cubxxw cubxxw merged commit ce5ec74 into telepace:main Jun 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants